Minor nodeletctl code reorg #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xagent003
requested review from
mithilarun,
pacharya-pf9,
poojaghumre and
supreeth90
xagent003
force-pushed
the
private/arjun/corereorg1
branch
from
d935416 to
0147ca8
Compare
xagent003
force-pushed
the
private/arjun/corereorg1
branch
from
0147ca8 to
02fc4ff
Compare
| ServicesCidr string | ||
| } | ||
|
|
||
| func setNodeletClusterCfg(cfg *BootstrapConfig, nodelet *NodeletConfig) { |
There was a problem hiding this comment.
Why not just return the config object instead of pointer? It makes the function much more readable from the definition.
| if _, err := os.Stat(nodeStateDir); os.IsNotExist(err) { | ||
| zap.S().Infof("Creating node state dir: %s\n", nodeStateDir) | ||
| if err := os.MkdirAll(nodeStateDir, 0777); err != nil { | ||
| return "", fmt.Errorf("Failed to create node state dir for host %s: %s", host.HostId, err) |
There was a problem hiding this comment.
Error strings should not start with upper case letters. General go convention.
| func GenNodeletConfigLocal(host *NodeletConfig, templateName string) (string, error) { | ||
| nodeStateDir := filepath.Join(ClusterStateDir, host.ClusterId, host.HostId) | ||
| if _, err := os.Stat(nodeStateDir); os.IsNotExist(err) { | ||
| zap.S().Infof("Creating node state dir: %s\n", nodeStateDir) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just mvoed some functions around, changed ordering. Moved the flat nodelet config struct and generation to a new file called config.go