Mark host up on notification #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.rc_util.syslogout(jsonData, syslog.LOG_INFO) | ||
|
|
||
| # Node is up | ||
| elif jsonData.get("type") == "rscGroup" and \ |
There was a problem hiding this comment.
Sachin, do we need a _check_repeated_notify here similar to the host-down case? or is this on purpose to retry enabling service on failure?
Author
There was a problem hiding this comment.
I started with that approach. Unfortunately, Masakari design expects to have 1 notification per host. Their duplicate checks for notification query based on host id. What it should be doing instead is query based on host id and event type.
So I opted for this approach instead.
I think we will need to change that logic anyway to handle multiple failures on same host.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds logic to mark host up on notification.