feat: get API private key from environment #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies CI setup by enabling the App Store Connect API private key to be passed as an environment variable and adds altool uploader compatibility.
Key changes:
- Modified JWT provider to accept private key as base64-encoded string from environment variable instead of reading from file system
- Added altool uploader compatibility with new authentication options
- Generated comprehensive test coverage for all domain modules
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Sources/Core/ASCCredentials/ASCCredentialsTrait.swift | Added apiPrivateKey property to read from APPSTORE_CONNECT_API_PRIVATE_KEY environment variable |
| Sources/Domain/JWTProvider/JWTProvider.swift | Updated to accept private key as base64 string parameter instead of reading from file |
| Sources/Domain/Uploader/Implementations/AltoolUploader.swift | Added apiPrivateKey support and AuthOption enum for altool authentication |
| Sources/Domain/Uploader/AppStoreConnectUploader.swift | Removed duplicate AuthOption enum definition |
| Sources/Domain/BlimpKit/Stages/3_Approach.swift | Updated import from Transporter to Uploader module |
| Sources/CLI/BlimpCLI/Subcommands/Approach.swift | Updated import from Transporter to Uploader module |
| Package.swift | Renamed Transporter module to Uploader and added JWTProvider tests |
| Tests/Domain/Uploader/UploaderTests.swift | Added comprehensive test coverage for uploader functionality |
| Tests/Domain/JWTProvider/JwtProvider.swift | Added comprehensive test coverage for JWT provider functionality |
| Tests/Domain/BlimpKit/BlimpTests.swift | Added comprehensive test coverage for BlimpKit functionality |
| Tests/Core/DeployHelpers/PlistHelpersTests.swift | Added additional test cases for plist helper functionality |
| Tests/Domain/Transporter/TransporterTests.swift | Removed placeholder test file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
memoto
approved these changes
Nov 4, 2025
Collaborator
Author
|
Just fixed some logs for shell commands here platacard/corredor#4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the CI setup.