Add tracing API #5
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the full tracing API (ish, might have missed some stuff). It is meant to be purely additive — the new files should not impact existing users in any way, yet. This is mostly to keep this from being a huge PR that breaks everything. When there was a file that already existed in the SDK that I thought should belong in the API (e.g. span kind), I have duplicated that file and made any necessary changes to match the specification:
baggage.luacontext.luaevent.luaid_generator.luaspan_context.luaspan_kind.luaspan_status.luatracestate.luautils.luaOnce the PR is merged, we can iteratively delete the files from the existing SDK to prefer the packages in the API, adjusting them as necessary.