Skip to content

Add Laravel 12.x support #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-triassi merged 5 commits into from
May 28, 2025
Merged

Add Laravel 12.x support #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e347302
chore: #18 update base illuminate dependency for Laravel 12.x support
m-triassi May 27, 2025
34fdda3
test: bring test set descriptions more inline with documentation exam…
m-triassi May 27, 2025
27ae45f
ci: #18 add php 8.3 for test suite runner / matrix
m-triassi May 27, 2025
0ddff11
ci: #18 migrate to new qlty action for coverage
m-triassi May 27, 2025
3dc3097
ci: #18 fix path to clover logs to match phpunits settings
m-triassi May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
fail-fast: true
matrix:
os: [ubuntu-latest, windows-latest]
php: [8.2]
php: [8.2, 8.3]
stability: [prefer-lowest, prefer-stable]

name: P${{ matrix.php }} - ${{ matrix.stability }} - ${{ matrix.os }}
Expand Down Expand Up @@ -65,11 +65,10 @@ jobs:
- name: Install dependencies
run: composer update --${{ matrix.stability }} --prefer-dist --no-interaction

- name: Test & publish code coverage
uses: paambaati/codeclimate-action@v5.0.0
env:
CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
- name: Run Tests with coverage
run: composer test-coverage

- uses: qltysh/qlty-action/coverage@v1
with:
coverageCommand: composer test-coverage
coverageLocations: |
${{github.workspace}}/build/logs/clover.xml:clover
token: ${{ secrets.QLTY_COVERAGE_TOKEN }}
files: build/logs/clover.xml
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"require": {
"php": "^8.2",
"spatie/laravel-package-tools": "^1.14.0",
"illuminate/contracts": "^10.0|^11.0"
"illuminate/contracts": "^10.0|^11.0|^12.0"
},
"require-dev": {
"laravel/pint": "^1.0",
Expand Down
10 changes: 5 additions & 5 deletions tests/Feature/LayoutsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

use function Pest\Laravel\artisan;

describe('It throws errors when layouts do not exist', function () {
describe('errors regarding layouts', function () {
it('throws an error when the Detail layout doesnt exist', function () {
Product::factory()->create()->layout();
})->throws(MissingLayoutException::class);
Expand All @@ -21,7 +21,7 @@
})->throws(MissingLayoutException::class);
});

describe('It returns Blade Layouts for Layoutables', function () {
describe('Layoutables return Blade layouts', function () {
beforeEach(function () {
setBladePath('sync');
artisan('contentable:sync')->assertExitCode(0);
Expand Down Expand Up @@ -74,7 +74,7 @@
});
});

describe('It returns Inertia Layouts for Layoutables', function () {
describe('Layoutables return Inertia Layouts', function () {
beforeEach(function () {
config()->set('contentable.layouts.mode', LayoutMode::InertiaJsx);
setInertiaPath('Sync');
Expand Down Expand Up @@ -120,7 +120,7 @@
});
});

describe('It returns layout options for blade', function () {
describe('layout options for blade', function () {
beforeEach(function () {
setBladePath('sync');
artisan('contentable:sync')->assertExitCode(0);
Expand Down Expand Up @@ -210,7 +210,7 @@
});
});

describe('It returns the default layouts for non-customizeable Layoutables with Inertia', function () {
describe('non-customizeable Layoutables with Inertia returns the default layouts', function () {
beforeEach(function () {
config()->set('contentable.layouts.mode', LayoutMode::InertiaJsx);
setInertiaPath('Sync');
Expand Down
4 changes: 2 additions & 2 deletions tests/Feature/SyncLayoutsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

use function Pest\Laravel\artisan;

describe('It syncs Layouts for Blade', function () {
describe('Layouts for Blade', function () {
beforeEach(function () {
setBladePath('sync');
});
Expand Down Expand Up @@ -143,7 +143,7 @@
});
});

describe('It syncs Layouts for Inertia', function () {
describe('Layouts for Inertia', function () {
beforeEach(function () {
config()->set('contentable.layouts.mode', LayoutMode::InertiaJsx);
setInertiaPath('Sync');
Expand Down