Add extraLabels to both subcontroller and vbsc pods #735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremy Doupe <jeremy@doupe.com>
Collaborator
|
@jdoupe can you please create a quick issue that describes what problem you're trying to solve? And link it to the PR here. Thanks! |
jdoupe
force-pushed
the
add-extra-labels
branch
from
1e03ca0 to
c7ba815
Compare
Signed-off-by: Jeremy Doupe <jeremy@doupe.com>
jdoupe
force-pushed
the
add-extra-labels
branch
from
c7ba815 to
ce2285c
Compare
Contributor
Author
|
Administrative note: (and you're probably already aware) the |
Signed-off-by: Jeremy Doupe <jeremy@doupe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #736
By adding the following:
vitessbackupschedules.spec.extraLabels
vitessbackupstorages.spec.extraLabels
vitessclusters.spec.backup.extraLabels
For vtbackup(-init), the code has just been modified to pass along the existing extraLabels on the tabletPool.
@mattlord / @frouioui