Updating the code to improve performance, customisability and avoid using dependencies#2
Open
Animenosekai wants to merge 4 commits intoplainoldcheese:masterfrom
Open
Updating the code to improve performance, customisability and avoid using dependencies#2Animenosekai wants to merge 4 commits intoplainoldcheese:masterfrom
Animenosekai wants to merge 4 commits intoplainoldcheese:masterfrom
Conversation
Author
|
Lol just saw that this project was 3 years old |
Animenosekai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I just got your project on my GitHub home page and wanted to help a bit by updating the code to improve its performance (avoid recomputing things, storing variables, unnecessary loops, etc.) and avoid using dependencies such as
termcolorI also made it a bit more customizable (with global variables at the top)
I just tested it, and it seems to be working fine 👌
And I wish you a Merry Christmas!