Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Conversation

@jhheider
Copy link
Contributor

@jhheider jhheider commented Jan 9, 2025

optional reduction in clarity to remove if cases and loops.

turns on testing, and unit tests the two helper functions.

note that this merges up to #17 , so careful with muddying that diff.

updated to split out the github actions work. this now merges to #20

@jhheider jhheider requested a review from mxcl January 9, 2025 22:12
@jhheider jhheider force-pushed the who-likes-math branch 6 times, most recently from 7a07259 to 9311664 Compare January 9, 2025 23:00
@jhheider
Copy link
Contributor Author

jhheider commented Jan 9, 2025

we should probably migrate to https://github.com/dtolnay/rust-toolchain since the action-rs jobs are 5 years old and archived. they are using set-output which will go away some day, probably sooner than we expect. see: https://www.reddit.com/r/rust/comments/z1mlls/actionsrs_github_actions_need_more_maintainers_or/

Edit: handled in #19

Base automatically changed from move-indicatif-to-cli to main January 10, 2025 16:19
@mxcl
Copy link
Member

mxcl commented Jan 10, 2025

It’s less clear, but it’s cool if it’s faster. Which I wonder about… you know?

Probs should be rebased.

@jhheider
Copy link
Contributor Author

the compiler is usually more than capable of figuring out real optimizations. people who care a lot use https://godbolt.org/noscript/rust to check.

@jhheider
Copy link
Contributor Author

I'll split up the stuff that's not math games

@jhheider jhheider changed the base branch from main to update-github-actions January 10, 2025 17:17
@jhheider jhheider force-pushed the update-github-actions branch from 5086bb8 to a0ded2c Compare January 10, 2025 17:19
@jhheider jhheider force-pushed the who-likes-math branch 3 times, most recently from beb5a06 to 403cfe5 Compare January 10, 2025 17:22
@jhheider jhheider changed the title use math to reduce clarity [optional] use math to reduce clarity Jan 10, 2025
@mxcl mxcl merged commit aa8116a into update-github-actions Jan 10, 2025
9 checks passed
@mxcl mxcl deleted the who-likes-math branch January 10, 2025 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants