pkgm ls & pkgm rm
#38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhheider
approved these changes
Mar 11, 2025
| while ((dir = dirs.pop()) != undefined) { | ||
| for await (const [path, { name, isDirectory, isSymlink }] of dir.ls()) { | ||
| if (!isDirectory || isSymlink) continue; | ||
| if (/^v\d+\./.test(name)) { |
Contributor
There was a problem hiding this comment.
should we test for ${basePath}/pkgs as well, to be careful?
Member
Author
There was a problem hiding this comment.
basePath not set in this function, isn’t it just one of the 2 on line 436?
Contributor
There was a problem hiding this comment.
shorthand. what i meant was, since anything could be here, testing to ensure the link looks like basePath/pkgs/whatever/vFOO/ is safer.
but that's probably a v1-grade safety feature too.
| if (isDirectory) { | ||
| dirs.push(resolved_path); | ||
| } else { | ||
| files.push(resolved_path); |
Contributor
There was a problem hiding this comment.
i wonder if we should test the inodes here to ensure nothing hinky:
$ pkgm i git
$ ln -f /usr/bin/git /usr/local/bin/git
$ pkgm u git
# problem? maybe not...
Member
Author
There was a problem hiding this comment.
we should be more careful, but that's a v1 feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.