Skip to content

add "audio/wav" filetype for uploads #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schellmax wants to merge 1 commit into
base: production
Choose a base branch
from
+2 −1
Open

add "audio/wav" filetype for uploads #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/engine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@
{
if (e.files[0].type == "audio/mp3"
|| e.files[0].type == "audio/wave"
|| e.files[0].type == "audio/wav"
Copy link
Copy Markdown

@suterma suterma Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found some more (which I am using in my own app), not sure it it really make sense, but just to mention it:
'audio/vnd.wave' /wav/,
'audio/x-wav' /wav/,
and also
'audio/x-aiff' /aiff/,

|| e.files[0].type == "audio/mpeg"
|| e.files[0].type == "audio/aiff"
|| e.files[0].type == "audio/flac"
Expand Down Expand Up @@ -2591,4 +2592,4 @@

PKAE._deps.engine = PKEng;

})( window, document, PKAudioEditor );
Copy link
Copy Markdown

@suterma suterma Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably just an additional line feed which should not get merged.

})( window, document, PKAudioEditor );