Open
Conversation
This was making the whole UI inaccessible for keyboard-only users
All buttons were missing an accessible name (the inner content was being stripped by the tooltip effect. Fixed by adding id to the inner <span> and referencing it with aria-labelledby
Allows for screen reader users to jump from region to region more easily
Changed wording (should avoid 'click here phrases', and link phrase now makes sense out of context ("load a sample audio file")
Doubled up on all hover styles with :focus equivalent Added new styles for all .pk_btn buttons
Set focus on OK button on load Changed link phrase for Githib so link makes sanes out of context
Author
|
Further things I will tackle:
|
Author
|
@pkalogiros - I am keen to engage with blind audio engineers to get some more feedback about how they would use this tool and how they would expect it to work for them. I'm quite keen to get your thoughts on my PR above first, though, as I don't want to raise anyone's hopes needlessly. Would appreciate it if you could take a look at my changes. Thanks |
Author
|
Not even an acknowledgement? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #35
A number of accessibility fixes for AudioMass :)
Summary:
See attachments for some before/after comparisons:
Before:
After:
Before:
After:
Before:
After: