Disconnecting ports queued for removal #4700
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider scenario: 1. Remove port 5. 2. Before port 5 is really removed, disconnect port 4->5. 3. Port 5 is removed. 4. When executing the disconnect 4->5, port 5 is now `NULL`, instead of ignoring the operation, it incorrectly executes it as disconnect 4->*. This PR addresses the issue in two places: - Disconnect execution: add a double check to ensure the specified port is valid before proceeding. - Prevention: introduce a 'removing' flag on ports to prevent connect/disconnect/configure operations from being queued while the port is pending removal.
sauwming
approved these changes
Dec 8, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a race condition in the PJMEDIA conference bridge where a disconnect operation on a port being removed could be executed incorrectly. Specifically, if a port is queued for removal and a disconnect operation is queued before the removal completes, the disconnect could execute after the port becomes NULL, causing it to be interpreted as a wildcard disconnect (e.g., disconnect 4->* instead of 4->5).
The fix implements a two-pronged approach:
- Prevention: Introduces a
removingflag on conference ports that prevents new connect/disconnect/configure operations from being queued while a port is pending removal - Validation: Adds double-checks in
op_disconnect_portsto verify ports are still valid when the operation executes
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
trengginas
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider scenario:
NULL, it incorrectly executes it as disconnect 4->*.Thanks to Sean Riley for the report.
This PR addresses the issue in two places: