This repository was archived by the owner on Jan 2, 2020. It is now read-only.
Open
Conversation
| } | ||
|
|
||
| function composeBoxIsShown() { | ||
| return $('#' + composeBoxId).length; |
Contributor
Author
There was a problem hiding this comment.
I'm not very happy with this. Is there any way to get that state of the application other than by accessing the DOM?
Member
There was a problem hiding this comment.
@treppo Not really, we just try to minimize the impact of messing with the dom by only changing things rendered inside the specific component. In this case, I would use the key combos to trigger events to specific components, that can deal with the dom manipulation it needs to do the action
Contributor
Author
There was a problem hiding this comment.
@bwagnerr i do trigger events on the specific components. only these events here have to be triggered on document. and therefore i have to check whether the compose box is open by accessing the dom…
dd08974 to
7a50d7d
Compare
ec1e675 to
eb9ce7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this pull–request to track work on #25
so far implemented: