feat(resolver): ✨ add X11 adapter implementations#18
Merged
justapithecus merged 1 commit intomainfrom Feb 7, 2026
Merged
Conversation
Implement all three resolver sub-interfaces for X11: - X11SessionResolver: focus detection via _NET_ACTIVE_WINDOW → _NET_WM_PID → process tree walk (wraps hotkey/x11.rs + hotkey/focus.rs) - X11HotkeyProvider: XGrabKey registration, X11 event thread, and classification bridge that emits HotkeyEvent on a channel - X11ClipboardProvider: xclip-based clipboard read/write Shared X11 connection via X11Shared::connect() with Arc<RustConnection>. Also makes hotkey submodule internals pub(crate) so resolver adapters can reuse existing code: - hotkey/mod.rs: focus, keybinding, x11 modules → pub(crate) - hotkey/x11.rs: X11Context fields, Atoms, LOCK_MASK, detect_numlock_mask → pub(crate) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
justapithecus
force-pushed
the
andrew/feat/resolver/x11
branch
from
8366784 to
80ebc65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement all three resolver sub-interfaces for X11, wrapping existing code from
hotkey/x11.rs,hotkey/keybinding.rs, andhotkey/focus.rs. This is PR 2 of 4 in the resolver abstraction implementation.Highlights
connect(), cloned into adapters viaArc_NET_ACTIVE_WINDOW→_NET_WM_PID→ process tree walk; mapsFocusError::NoSession→Ok(None),FocusError::Ambiguous→ErrXGrabKeyregistration with NumLock/CapsLock masking, spawns X11 event thread + classification bridge thread that emitsHotkeyEventon a channelxclip -selection clipboardfor read/writehotkey/submodule internalspub(crate)so adapters can reuse existing code without duplicationTest plan
cargo test— all 227 tests passcargo clippy --all-targets -- -Dwarnings— cleancargo fmt --check— clean🤖 Generated with Claude Code