feat(resolver): ✨ add resolver trait definitions and module structure#17
Merged
justapithecus merged 1 commit intomainfrom Feb 7, 2026
Merged
feat(resolver): ✨ add resolver trait definitions and module structure#17justapithecus merged 1 commit intomainfrom
justapithecus merged 1 commit intomainfrom
Conversation
Introduce the v2 resolver abstraction with three independent sub-interfaces for platform-specific behavior: - SessionResolver: focused session detection - HotkeyProvider: global key binding registration and event delivery - ClipboardProvider: system clipboard read/write Also defines ResolverError, ResolverSet, KeyBinding, HotkeyEvent, and HotkeyRegistration types. No implementations or consumers yet — traits are wired in subsequent PRs. See CONTRACT_RESOLVER.md. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce the v2 resolver abstraction module with trait definitions for three independent sub-interfaces that extract all platform-specific behavior into composable adapters. This is PR 1 of 4 in the resolver abstraction implementation.
Highlights
focused_session()maps the windowing environment to clippy sessionsregister()/unregister()for global key binding lifecycle, returnsHotkeyRegistrationwith anUnboundedReceiver<HotkeyEvent>channelread()/write()for system clipboard access (Send + Syncfor async broker contexts)Session,Hotkey,ClipboardvariantsBox<dyn Trait>ActionenumTest plan
cargo test— all 227 tests pass (no new tests; trait-only PR)cargo clippy --all-targets -- -Dwarnings— cleancargo fmt --check— clean🤖 Generated with Claude Code