Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Author
|
I rebuilt the change on a new device and noticed that test-reflock does not pass anymore. I'll investigate my changes further. |
rzhao271
commented
Jun 14, 2024
|
Thanks @rzhao271 for creating this PR. |
Author
|
I have switched to using condition variables and added another bitflag, giving the following advantages:
|
3 tasks
|
Is there any possibility of getting the changes merged here? Ideally OpenJDK wouldn't have a fork with the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream PR: zeromq/libzmq#4680
This PR would help Microsoft repositories indirectly consuming and rebuilding wepoll, such as microsoft/zeromq-prebuilt, to get into compliance with internal policies by using APIs only documented on learn.microsoft.com.
However, this PR also brings in a dependency on synchronization.lib, which raises the minimum required Windows version to Windows 8.This PR uses condition variables, bringing the minimum required Windows version to Windows Vista.
Older version of this PR that was for the dist branch: #36