Skip to content

Update wallet SDK dependency and add JitPack repository #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
oleonov wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Update wallet SDK dependency and add JitPack repository #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96bbbc4
Update wallet SDK dependency and add JitPack repository
oleonov Nov 14, 2025
c2b7994
Add signTransaction method to Signer interface and update transaction…
oleonov Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ dependencyResolutionManagement {
repositories {
google()
mavenCentral()
maven { url 'https://jitpack.io' }
}
}

Expand Down
2 changes: 1 addition & 1 deletion stellarkit/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ dependencies {
implementation "androidx.room:room-ktx:$room_version"
ksp "androidx.room:room-compiler:$room_version"

api 'org.stellar:wallet-sdk:2.0.0'
api 'com.github.piratecash:kotlin-wallet-sdk:169a2d4'

implementation 'androidx.core:core-ktx:1.16.0'
implementation 'androidx.appcompat:appcompat:1.7.0'
Expand Down
2 changes: 2 additions & 0 deletions stellarkit/src/main/java/io/horizontalsystems/stellarkit/Signer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
package io.horizontalsystems.stellarkit

import org.stellar.sdk.Transaction
import org.stellar.sdk.xdr.DecoratedSignature

interface Signer {
val publicKey: ByteArray
fun canSign(): Boolean
suspend fun sign(hash: ByteArray): DecoratedSignature
suspend fun signTransaction(transaction: Transaction): DecoratedSignature? = null
}
8 changes: 4 additions & 4 deletions stellarkit/src/main/java/io/horizontalsystems/stellarkit/StellarKit.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,8 @@ class StellarKit(
private suspend fun sendTransaction(transaction: Transaction): TransactionResponse {
if (!signer.canSign()) throw WalletError.WatchOnly

val txHash = transaction.hash()
val signature = signer.sign(txHash)
val signature = signer.signTransaction(transaction)
?: signer.sign(transaction.hash())
transaction.addSignature(signature)

return try {
Expand All @@ -256,8 +256,8 @@ class StellarKit(
val transaction = Transaction.fromEnvelopeXdr(transactionEnvelope, stellarNetwork)
if (!signer.canSign()) throw WalletError.WatchOnly

val txHash = transaction.hash()
val signature = signer.sign(txHash)
val signature = (transaction as? Transaction)?.let { signer.signTransaction(it) }
?: signer.sign(transaction.hash())
transaction.addSignature(signature)

return transaction.toEnvelopeXdrBase64()
Expand Down