Add automated cases to demonstrate archiving bug #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from our conversation on Friday.
I added three automated test cases: With archive enabled, without archive enabled, and with archive starting disabled, but enabled after the workflow completes. The first two behave as expected, but the third does not archive the workflow when manually deleted. This is confirmed by using the argo cli, viewing in the browser, as well as diff'ing the workflow YAML's prior to being deleted, in which the post-enabled archive case shows the archive label to be missing.
I believe this reproduces the exact situation I am observing on my instance.