forked from steely-glint/unrupt-demo
-
Notifications
You must be signed in to change notification settings - Fork 4
Add separate audio tracks, checkpoint system, and security fixes #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
viteinfinite
wants to merge
10
commits into
pipe:master
Choose a base branch
from
viteinfinite:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features: - Save host and guest audio tracks separately (-host.webm, -guest.webm) - Auto-save checkpoints every 60 seconds to IndexedDB - Checkpoint management UI (view, download, delete) - Improved browser close confirmation during recording - XSS vulnerability fix in checkpoint modal Co-Authored-By: Claude <noreply@anthropic.com>
- Add proper body padding - Add spacing between buttons in chosenAction row - Add margins to containers - Style duration badge - Improve footer layout with centered text and border - Add spacing to modal content - Add margins to small buttons Co-Authored-By: Claude <noreply@anthropic.com>
- Add stop confirmation modal with "Are you sure you want to end the recording?" - Modify stop button to show confirmation modal instead of directly stopping - Add confirmStop button handler that actually calls stopCall() Co-Authored-By: Claude <noreply@anthropic.com>
- Add restart confirmation modal asking "Are you sure you want to clear the current recording and start over?" - Add Restart button with refresh icon (hidden by default) - Add restartCall() function that reloads the page to start fresh - Show restart button after call ends - Wire up click handlers for restart button and confirm button Co-Authored-By: Claude <noreply@anthropic.com>
- Add a readonly text input field in the share modal to display the URL - Populate the URL field when the QR code is generated - Makes it easy to copy and paste the link Co-Authored-By: Claude <noreply@anthropic.com>
- Change github link from pipe/podcall to viteinfinite/podcall Co-Authored-By: Claude <noreply@anthropic.com>
…attachments The stop button click handlers were being attached inside onsignalingstatechange, which fires multiple times. This could cause issues. Move them to document ready so they're only attached once. Co-Authored-By: Claude <noreply@anthropic.com>
- Add getSupportedMimeType() to detect browser-supported MIME types - Add getBlobMimeType() to return appropriate MIME type for Safari (audio/mp4) - Update MediaRecorder creation to use supported MIME type - Update all blob creations to use dynamic MIME type - Update file extensions: .mp4 for Safari, .webm for other browsers - Fix saveData() and downloadBlob() to use correct extensions Safari doesn't support audio/webm codec well, preferring audio/mp4 instead. Co-Authored-By: Claude <noreply@anthropic.com>
1. Start Recording Button: - Add green "Start Recording" button (hidden until connection) - Modify addStream() to not auto-start recording - Add startRecording() function to manually start recorders - Show start button when connected, hide when recording starts 2. Mic Level Indicator: - Add progress bar showing microphone input level - Color-coded: red (too quiet), yellow (ok), green (good), yellow (too loud) - Updates 10 times per second using Web Audio API analyser - Shows gray when muted Co-Authored-By: Claude <noreply@anthropic.com>
When guest clicks "Accept" before host has finished setupRTC(), the offer fails because pc object doesn't exist yet. - Extract offer processing into processOffer() function - Check if pc exists before processing offer - If pc doesn't exist, queue the offer and retry every 100ms - This fixes the issue where guest has to refresh for host to see session Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features
-host.webmand-guest.webmSecurity
Notes
Co-Authored-By: Claude noreply@anthropic.com