Skip to content

Cherry-pick to release-v0.54.x #6270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 4 commits into from
Closed

Cherry-pick to release-v0.54.x #6270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
183e240
fix Details indent (#6248)
t-kikuc Sep 19, 2025
70d27b7
Fix failed tests on action planpreview (#6256)
khanhtc1202 Sep 22, 2025
4daaa75
Change test/lint workflow to correctly report completion status (#6257)
Warashi Sep 24, 2025
eccfa5f
Update RELEASE to v0.54.2 (#6267)
ffjlabo Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,18 @@ jobs:
# It is used to set as required check for the branch protection rules
go-lint-completed:
runs-on: ubuntu-24.04
if: always()
needs: go
steps:
- run: |
echo completed
- name: Check if all go lint jobs succeeded
# if jobs in the 'go' job matrix failed or were cancelled, this job will fail
# otherwise this job is marked as successful because all steps are skipped
run: exit 1
if: >-
${{
contains(needs.*.result, 'failure')
|| contains(needs.*.result, 'cancelled')
}}

web:
runs-on: ubuntu-24.04
Expand Down
12 changes: 10 additions & 2 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,18 @@ jobs:
# It is used to set as required check for the branch protection rules
go-test-completed:
runs-on: ubuntu-24.04
if: always()
needs: go
steps:
- run: |
echo completed
- name: Check if all go test jobs succeeded
# if jobs in the 'go' job matrix failed or were cancelled, this job will fail
# otherwise this job is marked as successful because all steps are skipped
run: exit 1
if: >-
${{
contains(needs.*.result, 'failure')
|| contains(needs.*.result, 'cancelled')
}}

web:
runs-on: ubuntu-24.04
Expand Down
2 changes: 1 addition & 1 deletion RELEASE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Generated by `make release` command.
# DO NOT EDIT.
tag: v0.54.1
tag: v0.54.2

releaseNoteGenerator:
showCommitter: false
Expand Down
2 changes: 1 addition & 1 deletion tool/actions-plan-preview/planpreview.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ func makeCommentBody(event *githubEvent, r *PlanPreviewResult, title string) str
for _, ppr := range app.PluginPlanResults {
fmt.Fprintf(&b, " - %s(%s): %s\n", ppr.PluginName, ppr.DeployTarget, ppr.PlanSummary)
}
fmt.Fprint(&b, " Details:\n")
fmt.Fprint(&b, "\n Details:\n")
for _, ppr := range app.PluginPlanResults {
fmt.Fprintf(&b, " - %s(%s):\n", ppr.PluginName, ppr.DeployTarget)

Expand Down
1 change: 1 addition & 0 deletions tool/actions-plan-preview/testdata/comment-plugin-has-failed-app.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Sync strategy: PIPELINE
Plugin(s): kubernetes
Summary:
- kubernetes(dt-1): 2 resources will be added, 1 resource will be deleted and 5 resources will be changed

Details:
- kubernetes(dt-1):
<details>
Expand Down
1 change: 1 addition & 0 deletions tool/actions-plan-preview/testdata/comment-plugin-one-success-app-multiple-plugins.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Sync strategy: PIPELINE
Summary:
- kubernetes(dt-1): 2 resources will be added, 1 resource will be deleted and 5 resources will be changed
- terraform(dt-2): 1 resource will be added, 2 resources will be deleted and 3 resources will be changed

Details:
- kubernetes(dt-1):
<details>
Expand Down
1 change: 1 addition & 0 deletions tool/actions-plan-preview/testdata/comment-plugin-one-success-app.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Sync strategy: QUICK_SYNC
Plugin(s): kubernetes
Summary:
- kubernetes(dt-1): 2 resources will be added, 1 resource will be deleted and 5 resources will be changed

Details:
- kubernetes(dt-1):
<details>
Expand Down