fix: prevent orphan elements from rendering#94
Merged
megheaiulian merged 1 commit intomainfrom Feb 1, 2026
Merged
Conversation
Elements that are constructed but never connected to the DOM will no longer render or run effects. This fixes issues where lit-html creates elements during template parsing that are never inserted into the DOM. The scheduler now starts with _active = false and only activates when connectedCallback is called (for custom elements) or resume() is called explicitly (for virtual components). Fixes #64
🦋 Changeset detectedLatest commit: 4cddfc7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for pionjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
megheaiulian
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Elements that are constructed but never connected to the DOM (orphan elements) will no longer render or run effects. This fixes issues where lit-html creates elements during template parsing that are never inserted into the DOM.
Problem
When lit-html renders a template containing a Pion custom element, it may create orphan elements - elements that are constructed but never connected to the DOM. Previously, these orphan elements would still render and run effects because Pion's scheduler started with
_active = true.This caused issues like:
Solution
The scheduler now starts with
_active = falseand only activates when:connectedCallbackis called (for custom elements)resume()is called explicitly (for virtual components)Changes
src/scheduler.ts: Changed_activeinitialization fromtruetofalsesrc/virtual.ts: Addedresume()call beforeupdate()since virtual components don't haveconnectedCallbacktest/use-effects.test.ts: Added test case for orphan elements not renderingTesting
Fixes #64