-
Notifications
You must be signed in to change notification settings - Fork 2
[EXECUTOR] Modified executor to place loops on student end #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oved run_mode function
Updated 4 student code test files
modified first 5 student_code tests
Revert "modified first 5 student_code tests"
Modified studentcode files
…d pi to ubuntu is runtime_update service file
3142008956
approved these changes
Mar 14, 2025
Member
3142008956
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests pass, if anything else comes up, we all blame Brandon.
ishan-monie
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary update in this pull request is updating executor such that loops now must be written by the students rather than done in executor itself. This was primarily a simplification of the code, ideally to deal with rare bugs around sleeping. It should also help students understand how exactly their code is running better.
Additionally, python version has been set to 3.11, the rasbian default. Tests have been updated to account for the new executor and python version.