Skip to content

Support Carthage xcframework #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shimastripe wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support Carthage xcframework #46

shimastripe wants to merge 2 commits into from

Conversation

@shimastripe
Copy link

@shimastripe shimastripe commented May 7, 2022

WHY

  • Carthage 0.38.0 supports--use-xcframeworks option.
  • XCFramework resolves to Carthage Xcode 12 workaround.

WHAT

@shimastripe
Copy link
Author

shimastripe commented May 7, 2022

@garrettmoon This PR supports PINOperation XCFramework. I'd like to continue to support for PINCache / PINRemoteImage. Could you please check it?

garrettmoon
garrettmoon approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@garrettmoon
Copy link
Collaborator

garrettmoon commented Nov 23, 2022

I don't know why the checks didn't run on your PR… Do these changes reflect what you wanted? #47

@shimastripe
Copy link
Author

shimastripe commented Nov 23, 2022

@garrettmoon It's ok! Thank you. And I commented nits point. #47 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettmoon garrettmoon garrettmoon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shimastripe @garrettmoon