Skip to content

Fix first example in README's problems #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
preoctopus wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix first example in README's problems #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e4727c
Add missing round-robin-strategy to readme example
Aug 19, 2015
4f64313
Rename instance to inst and add service-cache
Aug 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,15 @@ A (work-in-progress) dummy application is being produced that uses the library t
```clojure
(ns myservice
(:require [curator.framework :refer (curator-framework)]
[curator.discovery :refer (service-discovery service-instance service-provider instance instances services note-error)]))
[curator.discovery :refer (service-discovery service-instance service-provider instance instances services note-error round-robin-strategy service-cache)]))

;; services (and their instances) are registered by name
(def service-name "some-service")

;; create an instance of our service. we don't specify address
;; so it'll use a public address from our network interfaces.
;; payloads must be strings for now
(def instance (service-instance service-name
(def inst (service-instance service-name
"{scheme}://{address}:{port}"
1234
:payload "testing 123"))
Expand All @@ -48,7 +48,7 @@ A (work-in-progress) dummy application is being produced that uses the library t

;; next we create our service discovery, which uses the client
;; in the background to register our service instance
(def discovery (service-discovery client instance :base-path "/foo"))
(def discovery (service-discovery client inst :base-path "/foo"))
(.start discovery)

;; now we can see which services are registered
Expand Down