Skip to content

Fix dead code in content_block_stop handler and hardcoded provider names #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cursor wants to merge 1 commit into from
Closed

Fix dead code in content_block_stop handler and hardcoded provider names #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions apps/server/src/orchestration/Layers/ProviderCommandReactor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {
EventId,
type OrchestrationEvent,
type ProviderModelOptions,
type ProviderKind,
ProviderKind,
type ProviderStartOptions,
type OrchestrationSession,
ThreadId,
Expand Down Expand Up @@ -205,10 +205,11 @@ const make = Effect.gen(function* () {
}

const desiredRuntimeMode = thread.runtimeMode;
const currentProvider: ProviderKind | undefined =
thread.session?.providerName === "codex" || thread.session?.providerName === "claudeAgent"
? thread.session.providerName
: undefined;
const currentProvider: ProviderKind | undefined = Schema.is(ProviderKind)(
thread.session?.providerName,
)
? thread.session.providerName
: undefined;
const preferredProvider: ProviderKind | undefined = options?.provider ?? currentProvider;
const desiredModel = options?.model ?? thread.model;
const effectiveCwd = resolveThreadWorkspaceCwd({
Expand Down
4 changes: 0 additions & 4 deletions apps/server/src/provider/Layers/ClaudeAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1373,10 +1373,6 @@ function makeClaudeAdapter(options?: ClaudeAdapterLiveOptions) {
});
return;
}
const tool = context.inFlightTools.get(index);
if (!tool) {
return;
}
}
});

Expand Down