Skip to content

fix(web): replace hasOpenedDiff useState/useEffect latch with useRef #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mergemat wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −8
Open

fix(web): replace hasOpenedDiff useState/useEffect latch with useRef #1104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions apps/web/src/routes/_chat.$threadId.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ThreadId } from "@t3tools/contracts";
import { createFileRoute, retainSearchParams, useNavigate } from "@tanstack/react-router";
import { Suspense, lazy, type ReactNode, useCallback, useEffect, useState } from "react";
import { Suspense, lazy, type ReactNode, useCallback, useEffect, useRef } from "react";

import ChatView from "../components/ChatView";
import { DiffWorkerPoolProvider } from "../components/DiffWorkerPoolProvider";
Expand Down Expand Up @@ -176,7 +176,7 @@ function ChatThreadRouteView() {
const shouldUseDiffSheet = useMediaQuery(DIFF_INLINE_LAYOUT_MEDIA_QUERY);
// TanStack Router keeps active route components mounted across param-only navigations
// unless remountDeps are configured, so this stays warm across thread switches.
const [hasOpenedDiff, setHasOpenedDiff] = useState(diffOpen);
const hasOpenedDiffRef = useRef(diffOpen);
const closeDiff = useCallback(() => {
void navigate({
to: "/$threadId",
Expand All @@ -195,11 +195,7 @@ function ChatThreadRouteView() {
});
}, [navigate, threadId]);

useEffect(() => {
if (diffOpen) {
setHasOpenedDiff(true);
}
}, [diffOpen]);
if (diffOpen) hasOpenedDiffRef.current = true;

useEffect(() => {
if (!threadsHydrated) {
Expand All @@ -216,7 +212,7 @@ function ChatThreadRouteView() {
return null;
}

const shouldRenderDiffContent = diffOpen || hasOpenedDiff;
const shouldRenderDiffContent = diffOpen || hasOpenedDiffRef.current;

if (!shouldUseDiffSheet) {
return (
Expand Down