Skip to content

proxy: Upgrade TiFlash Proxy to fix known issue about BR and import#9706

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-7.5from
CalvinNeo:upgrade-release-7.5
May 28, 2025
Merged

proxy: Upgrade TiFlash Proxy to fix known issue about BR and import#9706
ti-chi-bot[bot] merged 1 commit intopingcap:release-7.5from
CalvinNeo:upgrade-release-7.5

Conversation

@CalvinNeo
Copy link
Copy Markdown
Member

@CalvinNeo CalvinNeo commented Dec 5, 2024

What problem does this PR solve?

Issue Number: close #9287, close #10141

Problem Summary: Update proxy to fix issues when running BR/import

What is changed and how it works?


pingcap/tidb-engine-ext#401 pick two BR/IMPORT related fixes from tikv

tiflash server side (this PR):

for import sst service, write RPC will only continue when the local region epoch is same as the epoch in request
for cleanup logic, when the region is not found or region epoch is changed, we can delete the sst file
client side (will open it in TiDB repo):

for write RPC, retry from write for the error message "RequestTooNew", and retry from rescan region for the error message "RequestTooOld"

Add a disk usage check when execute download and apply RPC from br.
When the disk is not Normal, the request would be rejected.

pick these two commit

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the panic issue caused by accidental deletion of SST files during running `IMPORT INTO` or `BR restore`

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2024
@JaySon-Huang
Copy link
Copy Markdown
Contributor

/hold

Running internal testing

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2024
@CalvinNeo
Copy link
Copy Markdown
Member Author

image

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved and removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Dec 6, 2024
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang JaySon-Huang force-pushed the upgrade-release-7.5 branch from cb30067 to b807118 Compare May 24, 2025 00:33
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 24, 2025
@JaySon-Huang JaySon-Huang changed the title Upgrade TiFlash Proxy to TiKV release-7.5 proxy: Upgrade TiFlash Proxy to fix known issue about BR and import May 24, 2025
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 27, 2025
@JaySon-Huang
Copy link
Copy Markdown
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 28, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label May 28, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented May 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 28, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented May 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-28 03:26:24.046980218 +0000 UTC m=+412314.418767674: ☑️ agreed by JaySon-Huang.
  • 2025-05-28 03:27:08.065325288 +0000 UTC m=+412358.437112753: ☑️ agreed by Lloyd-Pottiger.

@ti-chi-bot ti-chi-bot bot merged commit e8ea2e8 into pingcap:release-7.5 May 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants