Skip to content

Conversation

@michaelmdeng
Copy link
Contributor

@michaelmdeng michaelmdeng commented May 6, 2024

What problem does this PR solve?

Issue Number: close #710

Helps address #350.

Supports supports generating DMLs to resolve diffs in blob data. Essentially a copy of #709, with differences:

What is changed and how it works?

Generate correct DML to update different tables w/ blob data by converting data into hex for insert/replace/delete.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

Release note

None

@CLAassistant
Copy link

CLAassistant commented May 6, 2024

CLA assistant check
All committers have signed the CLA.

@michaelmdeng michaelmdeng force-pushed the mdeng/blob-compare branch from 688d99b to e728092 Compare May 6, 2024 16:21
@Leavrth
Copy link
Contributor

Leavrth commented May 7, 2024

please make format

@lyzx2001
Copy link

lyzx2001 commented May 7, 2024

please fix the fmt error in unit tests

@ti-chi-bot ti-chi-bot bot added the lgtm label May 8, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, lyzx2001

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-07 08:43:09.158536198 +0000 UTC m=+951542.915671770: ☑️ agreed by Leavrth.
  • 2024-05-07 15:40:40.123640929 +0000 UTC m=+976593.880776504: ✖️🔁 reset by michaelmdeng.
  • 2024-05-08 05:51:26.029920776 +0000 UTC m=+1027639.787056350: ☑️ agreed by lyzx2001.

@ti-chi-bot ti-chi-bot bot merged commit ee5de10 into pingcap:master May 8, 2024
michaelmdeng added a commit to michaelmdeng/tidb-tools that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sync-diff-inspector fix.sql can not execute when data has blob column type.

4 participants