Skip to content

Fix for #274 #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucholapl wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for #274 #275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbb6c6f
Fixed 'media_n_comment' to support threading and get ChildComments in…
lucholapl Jun 17, 2020
c40677d
Fixed 'media_n_comment' to support threading and get ChildComments in…
lucholapl Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions instagram_private_api/endpoints/media.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,21 +97,26 @@ def media_n_comments(self, media_id, n=150, reverse=False, **kwargs):
"""

endpoint = 'media/{media_id!s}/comments/'.format(**{'media_id': media_id})
query = {
'can_support_threading': 'true'
}
if kwargs:
query.update(kwargs)

comments = []
results = self._call_api(endpoint, query=kwargs)
results = self._call_api(endpoint, query=query)
comments.extend(results.get('comments', []))

while (((results.get('has_more_comments') and results.get('next_max_id'))
or (results.get('has_more_headload_comments') and results.get('next_min_id')))
and len(comments) < n):

if results.get('has_more_comments'):
kwargs.update({'max_id': results.get('next_max_id')})
query.update({'max_id': results.get('next_max_id')})
else:
kwargs.update({'min_id': results.get('next_min_id')})
query.update({'min_id': results.get('next_min_id')})

results = self._call_api(endpoint, query=kwargs)
results = self._call_api(endpoint, query=query)
comments.extend(results.get('comments', []))
if not (results.get('next_max_id') or results.get('next_min_id') or results.get('comments')):
# bail out if no max_id/min_id or comments returned
Expand Down