Skip to content

Conversation

@eracle
Copy link

@eracle eracle commented May 31, 2020

What does this PR do?

fixing #170 + sorting some imports.

Why was this PR needed?

otherwise it doesn't work

What are the relevant issue numbers?

#170

Does this PR meet the acceptance criteria?

  • [ don't know] Passes flake8 (refer to .travis.yml)
  • [ don't know] Docs are buildable
  • [ x] Branch has no merge conflicts with master
  • [ don't know] Is covered by a test

@Nuneshere
Copy link

can you please explain how that is working? I tried on my local account and seems to be not working well

@eracle
Copy link
Author

eracle commented Jun 13, 2020

You should ask to @javad94
I am only providing a fix based on his comment.

@javad94
Copy link

javad94 commented Jun 15, 2020

You should ask to @javad94
I am only providing a fix based on his comment.

Unfortunately my answer was for the old problem and it can't fix the new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants