Skip to content

Move weekly volume above activity chart#48

Merged
pineapplestrikesback merged 2 commits intomainfrom
feature/weekly-volume-compact
Jan 24, 2026
Merged

Move weekly volume above activity chart#48
pineapplestrikesback merged 2 commits intomainfrom
feature/weekly-volume-compact

Conversation

@pineapplestrikesback
Copy link
Owner

@pineapplestrikesback pineapplestrikesback commented Jan 24, 2026

Summary by CodeRabbit

  • Style
    • Redesigned Total Volume card: refreshed layout, border/background, two-column composition, updated loading placeholder, adjusted progress bar height/visuals, and refined typography for clearer hierarchy.
    • Replaced inline note with a right-aligned target summary and revised spacing for improved contrast and readability.
    • Reordered the Total Volume card on the dashboard to appear earlier in the layout.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Jan 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
gym-analytics Ready Ready Preview, Comment Jan 24, 2026 0:44am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 24, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

TotalVolumeCard receives a visual redesign (new two-column bordered layout, updated loading placeholder, progress bar, and typography). Dashboard render order is adjusted so TotalVolumeCard is moved earlier, now appearing before WeeklyActivityChart; no data-flow or public API changes.

Changes

Cohort / File(s) Summary
TotalVolumeCard visual redesign
src/ui/components/TotalVolumeCard.tsx
Reworked card layout: loading placeholder height/background changed, main card converted to a two-column bordered container with label, value + units, and right-aligned target block. Progress bar height/color adjusted and typography/spacing updated.
Dashboard component reordering
src/ui/pages/Dashboard.tsx
Moved TotalVolumeCard earlier in the page render order so it now appears before WeeklyActivityChart; single instance preserved, no data or visibility logic changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 I hopped a path of pixels bright,
I painted borders, trimmed the light,
A little card now stands more proud,
Moved up the row to show aloud,
Cheers — a rabbit’s tidy delight!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main change: moving the TotalVolumeCard component to render before WeeklyActivityChart in the Dashboard layout.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/ui/components/TotalVolumeCard.tsx`:
- Around line 15-16: The loading skeleton in TotalVolumeCard.tsx uses class
"h-16" which is shorter than the redesigned card and causes a layout shift;
update the placeholder height to match the final card's height (e.g., replace
"h-16" with the same height utility used by the rendered card) inside the
isLoading return so the skeleton and the rendered TotalVolumeCard share the same
vertical size.

@pineapplestrikesback pineapplestrikesback merged commit 0caeb87 into main Jan 24, 2026
3 of 4 checks passed
@claude
Copy link

claude bot commented Jan 24, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant