Open
Conversation
Author
Owner
|
sorry for taking long time to respond, been too busy ): I like the idea of not touching the PATH environment variable. and I don't think of any reason why someone would call the qfc python command-line directly without passing by the SHELL script. There are few issues with the code you added though. |
Instead of adding the location of qfc to the user’s PATH, this leaves PATH untouched and calls qfc at an arbitrary install location instead. In addition to not adding noise to the user’s path for just one script, this also allows having qfc installed to a location other than ~/.qfc.
b2a93de to
a532dde
Compare
Author
|
Ah, interesting pitfall. I amended the PR using Thanks for making qfc! |
|
Ping @pindexis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of adding the location of qfc to the user’s PATH, this
leaves PATH untouched and calls qfc at an arbitrary install
location instead.
In addition to not adding noise to the user’s path for just one
script, this also allows having qfc installed to a location other
than ~/.qfc.