update rediscache to 7.2.3 by dobet · Pull Request #7 · pikiwidb/rediscache

dobet · 2024-07-02T15:54:27Z

update rediscache to 7.2.3

coderabbitai · 2024-07-02T15:54:32Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

处理部分头文件处理部分头文件

解决部分代码飘红的问题增加部分头文件 fix cache coreump

修改t_hash.c文件修改t_set.c文件

修改编译错误增加漏了的文件恢复误删的类型增加头文件，避免报错

修改部分函数

…ning functions. 修改函数返回值注释掉引起编译错误的函数修改关键字造成的编译错误删除bit命令中多余的isbit字段增加漏掉的代碼增加漏掉的函數修改min和max的命名增加编译文件

dobet · 2024-07-04T16:21:15Z

当前测试release会出现很多问题，因此先开debug进行调试

当前遇到的第一个问题

连接pika -c pika_single.conf 这个进程，执行

ZINTERSTORE out 2 zset1 zset2 WEIGHTS 2 3

会在

这一行挂掉，不知道为什么，希望有大佬能协助排查一些

baixin01 · 2024-07-19T02:57:32Z

@baixin
整体架构修改
list类型

@chejinge
string类型
zset类型

@wangshaoyi
t_hash类型
t_set类型

baixin01 · 2024-07-26T06:57:33Z

@baixin
整体架构修改
list类型

@wuxianrong
string类型
zset类型

@wangshaoyi
t_hash类型
t_set类型

bitops.c

adlist.c

bitops.c

db.c

baixin01 · 2024-08-06T10:25:39Z

db.c

    }
+    dictSetVal(db->dict, de, val);
+
+    // TODO 不确定这里要怎么处理


目前review到这里

adlist.c

dobet and others added 3 commits January 31, 2024 01:51

delete 4.0 code and modify bitopt

f70b333

gaidong

da0eca3

RcBitPos

62a2f6b

dobet and others added 11 commits July 5, 2024 00:17

处理部分头文件

c4268c8

处理部分头文件处理部分头文件

evictionPoolPopulate

d59ac8f

解决部分代码飘红的问题增加部分头文件 fix cache coreump

fix

23b0129

fix CI

dd8322c

Update commondef.h

8e0859a

修改t_hash.c文件修改t_set.c文件

主要修改了t_string.c,改了t_zet.c的头文件

eaed4a3

修改了一些小bug

d10fea6

删去了t_zset.c中部分函数

5999e77

Remove some unnecessary functions, add some functions

71c9777

修改编译错误增加漏了的文件恢复误删的类型增加头文件，避免报错

zaddGenericCommand and zremrangeGenericCommand, getLongFromObject

e215ce4

修改部分函数

dobet force-pushed the 7.2.3 branch from 800a672 to 3c78a10 Compare July 4, 2024 16:19

clearocean621 mentioned this pull request Jul 5, 2024

Upgrade: using Redis 7 as redis cache OpenAtomFoundation/pikiwidb#2181

Open

AlexStocks requested review from chejinge and wangshao1 July 5, 2024 13:19

chejinge reviewed Aug 2, 2024

View reviewed changes

bitops.c Outdated Show resolved Hide resolved

chejinge reviewed Aug 2, 2024

View reviewed changes

bitops.c Outdated Show resolved Hide resolved

chejinge reviewed Aug 2, 2024

View reviewed changes

adlist.c Outdated Show resolved Hide resolved

chejinge reviewed Aug 2, 2024

View reviewed changes

bitops.c Outdated Show resolved Hide resolved

按照review情況修改代码@chejinge

f5f83a5