Fixes NAs in calcGlobalSafetyNet and calcCriticalConnectivityAreas #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esulting from inconsistent LUH years being used after LUH3 update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During working on the NAs in the weekly pipeline tests @georgsc and I found another issue related to the LUH3 update. calcGlobalSafetyNet results in NAs. The start of the computations that lead to the NAs is a negative Urban land area, resulting from (calcGlobalSafetyNetL57)
This subtraction is actually somewhat bogus, as landArea contains land areas from 2015 (hence the setting of the years). This was valid up to the LUH3 update as urbanLand only included "real" data until 2015 and then held the value constant. So the 2020 value used in the subtraction is actually a 2015 value. With the LUH3 update calcUrbanLandFuture was updated and now contains "real" 2020 data, thus we deduct 2020 urban land area from 2015 land area, which in this case leads to a negative value.