Conversation
There was a problem hiding this comment.
Pull request overview
Updates the app’s Electron runtime and build tooling to newer releases, along with associated lockfile refresh, to keep the desktop client current and improve performance/compatibility.
Changes:
- Bump
electronfrom^37.4.0to^40.1.0. - Bump
electron-builderfrom^26.0.12to^26.7.0(plus resulting dependency graph updates inpackage-lock.json). - Update
prettierto^3.8.1andlodash-esto^4.17.23.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates top-level dependency versions for Electron, electron-builder, prettier, and lodash-es. |
| package-lock.json | Regenerates the lockfile to reflect updated dependency graph (notably electron-builder/tooling deps). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "electron": "^40.1.0", | ||
| "electron-builder": "^26.7.0", | ||
| "prettier": "^3.8.1" |
There was a problem hiding this comment.
The Electron/electron-builder bump pulls in @electron/rebuild@4.x, which (per package-lock) declares an engines requirement of Node ">=22.12.0". Since package.json doesn’t declare a Node version/engines constraint, contributors/build environments running <22.12 may hit install/postinstall failures or engine-strict errors. Consider adding a package.json "engines.node" (and aligning any build docs/CI) to the minimum Node version required by the updated toolchain.
522b000 to
50a29ac
Compare
This brings electron and electron-builder up to their newest versions. I found the app a tad bit snappier and no noticeable regressions in a few days of usage.
Note: Might also be worth changing the defaultUserAgent string to show the actual Chromium version being used. Additionally, Electron swapped to Wayland as the default window manager in 38.
Something like:
Edit: A note, only tested this on a single CachyOS/Arch installation using pacman installation.