Open
Conversation
MickdeGraaf
requested changes
Nov 10, 2020
Comment on lines
+17
to
+18
| uint256 exitFeeRecipientShare; | ||
| uint256 exitFee; |
Member
There was a problem hiding this comment.
Can you verify this does not cause any storage corruption issues when upgrading existing contracts to this? @Evert0x
test/advancedPoolFunctionality.ts
Outdated
| }); | ||
| describe("Exit fee", async () => { | ||
| it("Setting the exit fee should work", async () => { | ||
| const tenPercent = constants.One.mul(10).pow(17) // 10% |
Member
There was a problem hiding this comment.
parseEther("0.1"); might be easier to understand. But its not really an issue.
test/basicPoolFunctionality.ts
Outdated
Comment on lines
+267
to
+268
| const fee = constants.One.mul(10).pow(16).mul(4); // 4% | ||
| const hundrerdPercent = constants.One.mul(10).pow(18) // 100% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement exit fee with percentage for FeeRecipient