Remove 'fail' argument from TruffleHog workflow, in workflow

[kazazes]

Important

Remove '--fail' argument from TruffleHog workflow in .github/workflows/trufflehog.yml.

• Workflow:
  • Removed --fail argument from extra_args in TruffleHog step in .github/workflows/trufflehog.yml.
  • TruffleHog will no longer fail the workflow based on scan results.

^{This description was created by for 2896207. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 2896207 in 48 seconds. Click for details.

• Reviewed 10 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. .github/workflows/trufflehog.yml:35

• Draft comment:
  Removing '--fail' flag changes the scan behavior so the workflow won't fail on detecting issues. Confirm this is the intended behavior and document the rationale if necessary.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% The comment is about a real change in the diff. It's pointing out a potentially significant change in behavior - the scan will no longer fail the workflow when issues are found. However, the comment asks for confirmation and documentation of rationale, which violates our rules about asking for confirmations or explanations. The change could be a security concern since it makes the secret scanning workflow non-blocking. Maybe we should keep the comment due to security implications? While security is important, our rules clearly state not to ask for confirmations or explanations. If the author wanted the workflow to be non-blocking, we should trust their judgment. Delete the comment because it violates our rule about asking for confirmations and explanations of intent, even though it correctly identifies a behavior change.

Workflow ID: wflow_4qq65p4F31zALqAP

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}