Merged
Conversation
Owner
Author
|
This PR resolves #3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in This PR
Changes to
Config::load_or_default()FnOnce() -> Configas its second argumentConfiginstead, without a closureThe issue with the original implementation was that
clippywould recommend removing the unneededreturnstatement. Doing so, however, would lead to errors becausesectioned_defaults!andgeneral_defaults!create configurations by runningConfig::builder().set("...", "...").build();without returning anything. The only other option that wouldn't be flagged by Clippy was to format your closure this way:... And then running
cargo fmtwould change it to this:This adds curly braces around the macro and breaks the function execution immediately.
With the new implementation, you can simply do this: