Skip to content

Fix Cabana::Grid::createLocalMesh memory space #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
streeve merged 1 commit into from
Sep 22, 2025
Merged

Fix Cabana::Grid::createLocalMesh memory space #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions unit_test/tstAPIC.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,7 @@ void collocatedTest()
UniformMesh<TEST_MEMSPACE> mesh( inputs, global_box, minimum_halo_size,
MPI_COMM_WORLD );
auto local_mesh =
Cabana::Grid::createLocalMesh<TEST_EXECSPACE>( *( mesh.localGrid() ) );
Cabana::Grid::createLocalMesh<TEST_MEMSPACE>( *( mesh.localGrid() ) );

// Particle mass.
double pm = 0.134;
Expand Down Expand Up @@ -723,7 +723,7 @@ void staggeredTest()
UniformMesh<TEST_MEMSPACE> mesh( inputs, global_box, minimum_halo_size,
MPI_COMM_WORLD );
auto local_mesh =
Cabana::Grid::createLocalMesh<TEST_EXECSPACE>( *( mesh.localGrid() ) );
Cabana::Grid::createLocalMesh<TEST_MEMSPACE>( *( mesh.localGrid() ) );

// Particle mass.
double pm = 0.134;
Expand Down
4 changes: 2 additions & 2 deletions unit_test/tstAdaptiveMesh.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ void constructionTest()
Kokkos::HostSpace(), nodes_1->view() );
auto local_space_1 = nodes_1->layout()->localGrid()->indexSpace(
Cabana::Grid::Ghost(), Cabana::Grid::Node(), Cabana::Grid::Local() );
auto local_mesh_1 = Cabana::Grid::createLocalMesh<TEST_EXECSPACE>(
auto local_mesh_1 = Cabana::Grid::createLocalMesh<TEST_MEMSPACE>(
*( nodes_1->layout()->localGrid() ) );
for ( int i = local_space_1.min( 0 ); i < local_space_1.max( 0 ); ++i )
for ( int j = local_space_1.min( 1 ); j < local_space_1.max( 1 ); ++j )
Expand Down Expand Up @@ -130,7 +130,7 @@ void constructionTest()
Kokkos::HostSpace(), nodes_2->view() );
auto local_space_2 = nodes_2->layout()->localGrid()->indexSpace(
Cabana::Grid::Ghost(), Cabana::Grid::Node(), Cabana::Grid::Local() );
auto local_mesh_2 = Cabana::Grid::createLocalMesh<TEST_EXECSPACE>(
auto local_mesh_2 = Cabana::Grid::createLocalMesh<TEST_MEMSPACE>(
*( nodes_2->layout()->localGrid() ) );
for ( int i = local_space_2.min( 0 ); i < local_space_2.max( 0 ); ++i )
for ( int j = local_space_2.min( 1 ); j < local_space_2.max( 1 ); ++j )
Expand Down
2 changes: 1 addition & 1 deletion unit_test/tstFieldManager.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ void adaptiveTest()
fm.array( FieldLocation::Node(), Field::PhysicalPosition<3>() );
auto host_coords = Kokkos::create_mirror_view_and_copy( Kokkos::HostSpace(),
nodes->view() );
auto local_mesh = Cabana::Grid::createLocalMesh<TEST_EXECSPACE>(
auto local_mesh = Cabana::Grid::createLocalMesh<TEST_MEMSPACE>(
*( nodes->layout()->localGrid() ) );
auto local_space = nodes->layout()->localGrid()->indexSpace(
Cabana::Grid::Ghost(), Cabana::Grid::Node(), Cabana::Grid::Local() );
Expand Down
4 changes: 2 additions & 2 deletions unit_test/tstPolyPIC.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ void collocatedTest()
UniformMesh<TEST_MEMSPACE> mesh( inputs, global_box, minimum_halo_size,
MPI_COMM_WORLD );
auto local_mesh =
Cabana::Grid::createLocalMesh<TEST_EXECSPACE>( *( mesh.localGrid() ) );
Cabana::Grid::createLocalMesh<TEST_MEMSPACE>( *( mesh.localGrid() ) );

// Time step size.
double dt = 0.0001;
Expand Down Expand Up @@ -376,7 +376,7 @@ void staggeredTest()
UniformMesh<TEST_MEMSPACE> mesh( inputs, global_box, minimum_halo_size,
MPI_COMM_WORLD );
auto local_mesh =
Cabana::Grid::createLocalMesh<TEST_EXECSPACE>( *( mesh.localGrid() ) );
Cabana::Grid::createLocalMesh<TEST_MEMSPACE>( *( mesh.localGrid() ) );

// Time step size.
double dt = 0.0001;
Expand Down
2 changes: 1 addition & 1 deletion unit_test/tstUniformMesh.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ void constructionTest()
Kokkos::HostSpace(), nodes_2->view() );
auto local_space_2 = nodes_2->layout()->localGrid()->indexSpace(
Cabana::Grid::Ghost(), Cabana::Grid::Node(), Cabana::Grid::Local() );
auto local_mesh_2 = Cabana::Grid::createLocalMesh<TEST_EXECSPACE>(
auto local_mesh_2 = Cabana::Grid::createLocalMesh<TEST_MEMSPACE>(
*( nodes_2->layout()->localGrid() ) );
for ( int i = local_space_2.min( 0 ); i < local_space_2.max( 0 ); ++i )
for ( int j = local_space_2.min( 1 ); j < local_space_2.max( 1 ); ++j )
Expand Down
Loading