avoid using error message as granularity in message details#6
Open
huttli wants to merge 2 commits intopicardy:masterfrom
Open
avoid using error message as granularity in message details#6huttli wants to merge 2 commits intopicardy:masterfrom
huttli wants to merge 2 commits intopicardy:masterfrom
Conversation
Author
|
was this repo ready for travis-ci integration at all? I thought I've fixed the function assertion on in the test file. local 'npm run test' was all passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the assert interface, putting the error message in the granularity parameter's position will get us something like:
assert.sameMoment(a, b, "error message");error message: expect a to be the same as b (granularity: error message)The granularity should be skipped since it's not provided at all. And we shouldn't be taking the error message as granularity either.