EXPERIMENTAL!! jump table address decoder + support 24k and 32k drive roms #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This is how VICE does it and it is cleaner. Just be careful though and make sure that everything is still mapped correctly. readNULL returning 0 will break a lot of copy protections. |
unmapped ram returns address >> 8
Contributor
Author
|
I’ve done the >>8 but closing for now - will re open when I look at cleaning it up properly |
added memory map shadows
Contributor
Author
|
Can you pls take another peek at this ? I’ve added support for 24k and 32k drive roms (like dolphin and sjiffy) |
Contributor
Author
|
This has merge conflicts with my PR #72 |
penfold42
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For review and discussion only at this stage..
It does work - by work I mean a d64copy works fine. I haven’t tested more yet.
What’s the best way to profile this ?
At the expense of a little ram, this should be quicker - certainly more predictable.
I’m no c++ dev, but maybe a MemoryDevice base class for the VIA, rom and ram would make this much cleaner. The intermediate functions are horrible.
The big advantage is zero additional run time overhead as we add more config options - additonal rom, ram, 1581, 1571 support and so forth