Fix LED/SOUND GPIO regression on RPI2/RPI3 without reverting RPI0 changes #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent GPIO adjustments for Raspberry Pi Zero changed LED and SOUND initialisation. While required for RPI0, this caused a regression on RPI2/RPI3 in the IEC open-drain path. Restore correct behaviour on RPI2/RPI3 by configuring the affected GPIOs via direct GPFSEL access, keeping the RPI0 fix intact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recent GPIO changes made to support Raspberry Pi Zero (RPI0) altered the
initialisation of the LED and SOUND pins. While correct for RPI0, this
introduced a regression on RPI2 and RPI3 when using the IEC open-drain path.
Details
This change restores correct LED and SOUND behaviour on RPI2/RPI3 by
configuring the affected GPIOs via direct GPFSEL access, while keeping
the existing RPI0 fix intact.
The fix is limited to the non-split IEC path and does not affect the
split-IEC configuration.
Motivation
The issue was observed by users and discussed publicly, where workarounds
reverted the RPI0 fix entirely. This patch avoids a rollback and instead
applies a platform-specific correction.