Add binary prefixes for digital storage#90
Open
gkaklas wants to merge 3 commits intophysphil:developfrom
Open
Conversation
gkaklas
force-pushed
the
binary-prefixes
branch
from
c3b8bc3 to
0cf859a
Compare
editicalu
approved these changes
Apr 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binary storage units are not very known, however they're the reason a 32GB flash drive shows up as 29GiB when plugged in a computer, a 1TB drive as ~900GiB and so on. I think that this PR is helpful for a user wanting to do such conversions, as doing so with a calculator requires all the intermediate 1024*1024*1024... calculations.
I wasn't sure how to leave untranslated entries for strings, so I just went ahead and added duplicate entries in every
values-*/strings.xml. I'm not sure I like it and I don't know how is the correct way to do this, so if there is a better way please let me know and I'll just rebase.This closes #46.