Gradle and major dependency updates#200
Open
TacoTheDank wants to merge 7 commits intophysphil:developfrom
Open
Gradle and major dependency updates#200TacoTheDank wants to merge 7 commits intophysphil:developfrom
TacoTheDank wants to merge 7 commits intophysphil:developfrom
Conversation
Owner
|
Thanks for taking care of this 🙂You're right, I am working on a Kotlin rewrite, but like most things it's taking longer than expected. I'll take a look at this PR soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know that much of this probably isn't necessary, since you're migrating the entire project to Kotlin, but it was fun to practice. Also I don't know what libraries you intend to use in the Kotlin app (there's a nifty library called RxKotlin). Maybe you could release a final 5.x version with the last changes before 6.
1st commit
2nd commit
3rd commit
4th commit
5th commit
6th commit
7th commit