Explain the effect of current job on monitoring #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current job concept is explained directly on the continuous monitoring page since this is where the impact is most clearly seen.
kylewillmon
force-pushed
the
cm-default-job
branch
from
cc28089 to
969d3f9
Compare
maxrake
requested changes
Nov 21, 2024
Contributor
maxrake
left a comment
maxrake
left a comment
There was a problem hiding this comment.
Small grammar change needed, plus a couple of suggestions.
Contributor
|
It might be worth mentioning how the default label can only be set by (project/group/org?) admins. I can imagine someone without the necessary permissions reading this document, looking at the Phylum UI, and wondering why they don't see any way to change/set the default label. |
Contributor
Author
The operation only requires member access. I believe you have found a UI bug since the button to set the default label is only shown to admins. CLI correctly allows the operation for group/org members. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current job concept is explained directly on the continuous monitoring page since this is where the impact is most clearly seen.
This PR should be the final change needed for the default label story