Add phylum firewall log subcommand
#1551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd-work
force-pushed
the
aviary_logs
branch
2 times, most recently
from
2eedf40 to
4f5f4fa
Compare
This patch adds the new `phylum firewall log` to allow checking the Aviary log from the CLI. While the UI gives a more user-friendly overview, this should be complementary by giving access to the data in a structure closer to the original layout. The CLI arguments allow applying most filters exposed by the API, but combine the individual package components into a PURL to avoid an excessive number of arguments. Currently neither the `--json` output nor the pretty-printer have a way to paginate through the logs. While this could be done either automatically or by manually specifying the pagination offset, it seems to me like the limit of 10_000 entries per page should be sufficient for all current usecases. Contrary to our existing timestamp columns, the timestamp in the output table uses nanosecond precision. The additional precision seems worthwhile in this case since this automatically groups versions together if they were submitted for analysis as a batch.
maxrake
requested changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the new
phylum firewall logto allow checking the Aviary log from the CLI.While the UI gives a more user-friendly overview, this should be complementary by giving access to the data in a structure closer to the original layout.
The CLI arguments allow applying most filters exposed by the API, but combine the individual package components into a PURL to avoid an excessive number of arguments.
Currently neither the
--jsonoutput nor the pretty-printer have a way to paginate through the logs. While this could be done either automatically or by manually specifying the pagination offset, it seems to me like the limit of 10_000 entries per page should be sufficient for all current usecases.Contrary to our existing timestamp columns, the timestamp in the output table uses nanosecond precision. The additional precision seems worthwhile in this case since this automatically groups versions together if they were submitted for analysis as a batch.