Fix certificate check option naming #1546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an inconsistency between the `ignore_certs` configuration option and the `--no-check-certificate` CLI flag by changing the CLI flag to be `--ignore-certs` with an alias for the old version. Closes #480.
matt-phylum
approved these changes
Dec 2, 2024
Contributor
matt-phylum
left a comment
matt-phylum
left a comment
There was a problem hiding this comment.
--no-check-certificate is the name of the parameter used by wget, but if it's just wget that doesn't seem like a standard that we'd want to stick with. I like when the name contains something like "insecure", but it's probably okay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an inconsistency between the
ignore_certsconfiguration option and the--no-check-certificateCLI flag by changing the CLI flag to be--ignore-certswith an alias for the old version.Closes #480.