Ignore platform-specific gems #1543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue in the Ruby `Gemfile.lock` parser where version-specific dependencies like `ffi (1.17.0-x86_64-linux-gnu)` would cause the parser to crash. Since new Ruby Gems are not allowed to contain dashes, this patch simply discards Gems that contain a `-` in their version. There are technically two versions of `asciidoctor-reducer` (`1.0.0-rc.1` and `1.0.0-beta.1`) which contain dashes, but those are neither commonly used, nor a security risk. Closes #1540.
maxrake
approved these changes
Nov 25, 2024
Contributor
maxrake
left a comment
maxrake
left a comment
There was a problem hiding this comment.
The code was reviewed and the changes confirmed with local testing. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in the Ruby
Gemfile.lockparser where version-specific dependencies likeffi (1.17.0-x86_64-linux-gnu)would cause the parser to crash.Since new Ruby Gems are not allowed to contain dashes, this patch simply discards Gems that contain a
-in their version. There are technically two versions ofasciidoctor-reducer(1.0.0-rc.1and1.0.0-beta.1) which contain dashes, but those are neither commonly used, nor a security risk.Closes #1540.