chore: fix triggers with return values#59
Merged
0xgregthedev merged 2 commits intomasterfrom Aug 6, 2025
Merged
Conversation
fredo
reviewed
Aug 5, 2025
|
nice! Just to get it right, by validating against test_evm we fix both, return value and committing state (as we discussed in the knowledge transfer), right? |
fredo
approved these changes
Aug 5, 2025
Co-authored-by: Frederik <luehrs.fred@gmail.com> Signed-off-by: GregTheDev <gbcurtis98@outlook.com>
Author
Yep that is correct. When we force a revert we still need to update journal tx depth for expect revert calls but otherwise should be pretty seamless |
fredo
approved these changes
Aug 6, 2025
mateo-mro
pushed a commit
that referenced
this pull request
Dec 2, 2025
* chore: fix regressions * Update crates/cheatcodes/src/credible.rs Co-authored-by: Frederik <luehrs.fred@gmail.com> Signed-off-by: GregTheDev <gbcurtis98@outlook.com> --------- Signed-off-by: GregTheDev <gbcurtis98@outlook.com> Co-authored-by: Frederik <luehrs.fred@gmail.com>
mateo-mro
pushed a commit
that referenced
this pull request
Dec 22, 2025
* chore: fix regressions * Update crates/cheatcodes/src/credible.rs Co-authored-by: Frederik <luehrs.fred@gmail.com> Signed-off-by: GregTheDev <gbcurtis98@outlook.com> --------- Signed-off-by: GregTheDev <gbcurtis98@outlook.com> Co-authored-by: Frederik <luehrs.fred@gmail.com>
mateo-mro
pushed a commit
that referenced
this pull request
Dec 22, 2025
* chore: fix regressions * Update crates/cheatcodes/src/credible.rs Co-authored-by: Frederik <luehrs.fred@gmail.com> Signed-off-by: GregTheDev <gbcurtis98@outlook.com> --------- Signed-off-by: GregTheDev <gbcurtis98@outlook.com> Co-authored-by: Frederik <luehrs.fred@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug for triggers with return values.
also executes triggers that were valid and executed against test evm