Conversation
odyslam
force-pushed
the
feat/submit-assertion
branch
from
0a9b86d to
de8a403
Compare
makemake-kbo
approved these changes
Feb 14, 2025
|
|
||
| #[derive(clap::Parser)] | ||
| pub struct DASubmitArgs { | ||
| // FIXME(Odysseas): Replace localhost with the actual DA URL from our infrastructure |
Contributor
There was a problem hiding this comment.
nit: fun thing to do would be to have localhost be for the dev profile and infa url for release
| async fn submit_assertion( | ||
| &self, | ||
| project: &Project, | ||
| assertions: Vec<&AssertionForSubmission>, |
Contributor
There was a problem hiding this comment.
nit: &[AssertionForSubmission] (or &[&AssertionForSubmission]) is better
unless i need a vec specific feature or to own i much prefer &[]
czepluch
reviewed
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the CLI command to submit assertions. It enables users to select projects from their list of projects and also assertions that have already been submitted to the DA and are cached.
It also creates a config/cache file and directory to store information across CLI runs such as the auth token.